Add field exists filter button to doc table#6166
Conversation
|
Jenkins standing by to test this. If you aren't a maintainer, you can ignore this comment. Someone with commit access, please review this and clear it for Jenkins to run; then say 'jenkins, test it'. |
|
jenkins, test it |
|
What about just making the field name itself clickable? None of these icons really say "field exists" to me. Anyone else have any thoughts on the matter? |
|
Jenkins standing by to test this. If you aren't a maintainer, you can ignore this comment. Someone with commit access, please review this and clear it for Jenkins to run; then say 'jenkins, test it'. |
|
jenkins, test it |
|
@spalger Happy to fixup if you and @rashidkpc are happy with the design? |
|
An asterisk would work, can you update the screenshot and merge master? |
|
@rashidkpc Done |
|
jenkins, test it |
|
Looks like this needs tests |
|
@rashidkpc Added tests |
|
jenkins, test it |
| filter: '=', | ||
| columns: '=' | ||
| columns: '=', | ||
| updateFilterInQuery: '=filter' |
There was a problem hiding this comment.
Why do you need updateFilterInQuery in query here? Its bound to the same thing as filter?
|
@rashidkpc Done. Sorry, was some blind copy & paste going on there. |
|
jenkins, test it |
|
LGTM! |
4 participants
Closes #6092